Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drum Randomizer #122

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

alter-alter
Copy link
Contributor

In KIT mode, while holding down the audition pad(s), pressing the [RANDOM] pad will randomly select a sample from the folder containing each sample.

Demo: https://youtu.be/gw_8WSeZs8o
* The button combinations in the video are different from the current implementation.

Known Issues:

  • Undo functionality is not available.
  • There is a limit on the number of sample files within a folder (currntly 25 files) for processing speed.

@m-m-adams
Copy link
Collaborator

Since this changes user facing behaviour could you place it in the community settings menu - #59 ? There's still ongoing discussion here so the contributing guide isn't in the main repo yet but the discussion can be found in #56

@alter-alter
Copy link
Contributor Author

alter-alter commented Jun 30, 2023

Thanks for the information. Should this randomizer feature be turned Off by default?

@sapphire-arches
Copy link
Collaborator

It doesn't override any existing behavior right, so I think having it enabled by default is OK.

@alter-alter
Copy link
Contributor Author

It doesn't override any existing behavior right, so I think having it enabled by default is OK.

Thank you!

@litui litui assigned litui and alter-alter and unassigned litui Jun 30, 2023
@litui litui added the enhancement New feature or request label Jun 30, 2023
@litui litui self-requested a review June 30, 2023 17:30
Copy link
Collaborator

@litui litui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works on the hardware, we're good to go.

@litui litui requested a review from jamiefaye June 30, 2023 17:34
@litui litui merged commit 48b4baa into SynthstromAudible:community Jun 30, 2023
5 checks passed
@alter-alter
Copy link
Contributor Author

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants