Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantize #129

Merged
merged 2 commits into from Jul 5, 2023
Merged

Quantize #129

merged 2 commits into from Jul 5, 2023

Conversation

alter-alter
Copy link
Contributor

@alter-alter alter-alter commented Jul 1, 2023

This is a feature that enables quantization after recording.

In the Clip view, press the Note pad + shift + ◄► knob combination to switch between the NUDGE, QUANTIZE, and QUANTIZE ALL ROW modes. While pressing the note pad(s), press+turn the ◄►knob to the right to apply quantize, and to the left to apply humanize.

Demo: https://youtu.be/iAL447a1jD4

Issue:

  • The switch operation between the Nudge feature and the Quantize feature is somewhat difficult.

@litui litui added the enhancement New feature or request label Jul 3, 2023
Copy link
Collaborator

@sapphire-arches sapphire-arches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine from a functional perspective. I think the user interface could use some iteration (it feels somewhat clunky to select). Spitballing some ideas:

  • We could steal the tempo encoder while a pad is pressed, but mis-input could be very destructive (though it is undoable, I think).
  • shift + keyboard to enter a quantize mode where tapping notes quantizes them and tapping the audition pad quantizes the whole row. This has the disadvantage of making the UI even more modal than it already is, but might be justified.

@alter-alter
Copy link
Contributor Author

alter-alter commented Jul 5, 2023

Changed the quantize UI to use the tempo encoder. I think it is now more intuitive.

Useage:
In the Clip view, while holding down the Note pad(s), turning the Tempo knob to the right applies quantize, and turning it to the left applies humanize.

While holding down the Note pad, pressing and turning the Tempo knob applies quantize/humanize to all rows.

*This feature can be turned On/Off in the community settings menu.

@jamiefaye
Copy link
Collaborator

Forgive my ignorance, but what is the Note Pad?

@jamiefaye
Copy link
Collaborator

OK, I see that you have to "turn on" this feature from a global menu.

@jamiefaye jamiefaye merged commit beaac82 into SynthstromAudible:community Jul 5, 2023
5 checks passed
@alter-alter
Copy link
Contributor Author

Forgive my ignorance, but what is the Note Pad?

I apologize for the lack of clarity. It's the pad on which the note is placed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants