Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal Shift for Audio Clips #141

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Horizontal Shift for Audio Clips #141

merged 6 commits into from
Jul 5, 2023

Commits on Jul 5, 2023

  1. Implement Horizontal shift for audio clips

    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    77cf3d0 View commit details
    Browse the repository at this point in the history

  2. refactor: add getCurrentClip() to clip_view.cpp

    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    700ce0f View commit details
    Browse the repository at this point in the history

  3. Unify Audio- and instrument clip horizontal shift

    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3e0d020 View commit details
    Browse the repository at this point in the history

  4. Update cluster reasons on audio clip horizontal shift

    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0dd666c View commit details
    Browse the repository at this point in the history

  5. Disallow shiftHorizontally in more cases, stop audio while changing v… 

    …alues

I don't actually know if the latter is needed, but the sample_marker_editor
does it when changing these values, so it seems reasonable to do as well.

I also removed the "CANT" message when shiftHorizontally fails, as i felt it
to be a bit redundant - usually it fails for trivial reasons, such as start
or end reached
    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0d52012 View commit details
    Browse the repository at this point in the history

  6. Add audio clip horizontal shift to communityfeatures.md

    @topisani
    topisani committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    479a27b View commit details
    Browse the repository at this point in the history