-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midi Takeover Mode #170
Merged
jamiefaye
merged 12 commits into
SynthstromAudible:community
from
seangoodvibes:community
Jul 14, 2023
Merged
Midi Takeover Mode #170
jamiefaye
merged 12 commits into
SynthstromAudible:community
from
seangoodvibes:community
Jul 14, 2023
Commits on Jul 7, 2023
-
Midi Pickup Mode enables the Deluge to ignore Midi CC Values from Controllers that are out of Sync with the Deluge. For example, if an External Midi Controller is sending a Midi CC Value of 0 to the Deluge for a Parameter on the Deluge that is currently set to an equivalent Midi CC Value of 127, then the devices are out of sync. The Deluge will ignore Midi CC Values from the Midi Controller until the Midi Controller has been "reset" / matches the current Parameter Value on the Deluge. It does this by comparing the incoming Midi CC Value with the Deluge's internal Knob Position (which is derived from the Current Parameter Value). The Deluge Internal Knob Position can be converted to a Midi CC Value and Vice Versa by subtracting 64 from the Midi CC Value or adding 64 to the Deluge's Knob Position. If the difference between the Deluge's Internal Knob Position and the Midi CC Value is greater than +/- 1, then the Midi CC Value is ignored the Parameter's Value will not be changed. The feature can be disabled using the Community Features menu in Settings. on the Deluge.
Configuration menu - View commit details
-
Copy full SHA for 467bd6b - Browse repository at this point
Copy the full SHA 467bd6bView commit details
Commits on Jul 12, 2023
-
Updated the code to: - Move Midi Takeover Mode settings from Community Menu to Midi Menu - Add Value Scaling mode - Save Midi Takeover Settings to Midi XML file - Load Midi Takeover Settings from Midi XML file
Configuration menu - View commit details
-
Copy full SHA for d234200 - Browse repository at this point
Copy the full SHA d234200View commit details -
Resolved runtime_feature_settings.h file conflict
Replaced file with latest version from community
Configuration menu - View commit details
-
Copy full SHA for b59299a - Browse repository at this point
Copy the full SHA b59299aView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa7850b - Browse repository at this point
Copy the full SHA aa7850bView commit details
Commits on Jul 13, 2023
-
Corrections made based on feedback
Per m-m-adams feedback, I have made the following changes: 1) moved takeover mode description to community features.md 2) replaced * 1000000 multiplication with << 20 3) replaced / 1000000 division with >> 20
Configuration menu - View commit details
-
Copy full SHA for 8775ad7 - Browse repository at this point
Copy the full SHA 8775ad7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c9adb - Browse repository at this point
Copy the full SHA 98c9adbView commit details
Commits on Jul 14, 2023
-
Corrected formatting issues identified by clang-format style check
Configuration menu - View commit details
-
Copy full SHA for b9b9639 - Browse repository at this point
Copy the full SHA b9b9639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6108390 - Browse repository at this point
Copy the full SHA 6108390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3696294 - Browse repository at this point
Copy the full SHA 3696294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 368261c - Browse repository at this point
Copy the full SHA 368261cView commit details -
Ok now I think I've got it! Let's try this :)! I ran the clang format script this time.
Configuration menu - View commit details
-
Copy full SHA for 9652f0c - Browse repository at this point
Copy the full SHA 9652f0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d5318e - Browse repository at this point
Copy the full SHA 6d5318eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.