Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi Takeover Mode #170

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Commits on Jul 7, 2023

  1. Midi Pickup Mode

    Midi Pickup Mode enables the Deluge to ignore Midi CC Values from Controllers that are out of Sync with the Deluge.
    
    For example, if an External Midi Controller is sending a Midi CC Value of 0 to the Deluge for a Parameter on the Deluge that is currently set to an equivalent Midi CC Value of 127, then the devices are out of sync.
    
    The Deluge will ignore Midi CC Values from the Midi Controller until the Midi Controller has been "reset" / matches the current Parameter Value on the Deluge.
    
    It does this by comparing the incoming Midi CC Value with the Deluge's internal Knob Position (which is derived from the Current Parameter Value).
    
    The Deluge Internal Knob Position can be converted to a Midi CC Value and Vice Versa by subtracting 64 from the Midi CC Value or adding 64 to the Deluge's Knob Position.
    
    If the difference between the Deluge's Internal Knob Position and the Midi CC Value is greater than +/- 1, then the Midi CC Value is ignored the Parameter's Value will not be changed.
    
    The feature can be disabled using the Community Features menu in Settings. on the Deluge.
    seangoodvibes committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    467bd6b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Update to Midi Takeover

    Updated the code to:
    - Move Midi Takeover Mode settings from Community Menu to Midi Menu
    - Add Value Scaling mode
    - Save Midi Takeover Settings to Midi XML file
    - Load Midi Takeover Settings from Midi XML file
    seangoodvibes committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d234200 View commit details
    Browse the repository at this point in the history
  2. Resolved runtime_feature_settings.h file conflict

    Replaced file with latest version from community
    seangoodvibes committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b59299a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa7850b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Corrections made based on feedback

    Per m-m-adams feedback, I have made the following changes:
    
    1) moved takeover mode description to community features.md
    
    2) replaced * 1000000 multiplication with << 20
    
    3) replaced / 1000000 division with >> 20
    seangoodvibes committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8775ad7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98c9adb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Fixed formatting issues

    Corrected formatting issues identified by clang-format style check
    seangoodvibes committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b9b9639 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6108390 View commit details
    Browse the repository at this point in the history
  3. Trying again to fix formatting!

    Hopefully this works!
    seangoodvibes committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    3696294 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    368261c View commit details
    Browse the repository at this point in the history
  5. Fixed clang format issues

    Ok now I think I've got it! Let's try this :)! I ran the clang format script this time.
    seangoodvibes committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9652f0c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6d5318e View commit details
    Browse the repository at this point in the history