runtime features: make style of patch cable strength selectable #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses SynthstromAudible#158 drawBar() method is moved unmodified from IntegerContinuous to Number as it only depends of attributes of the Number base class
Merged
via the queue into
SynthstromAudible:community
with commit Jul 11, 2023
c392533
2 checks passed
bfredl
added a commit
to bfredl/DelugeFirmware
that referenced
this pull request
Jul 11, 2023
- SynthstromAudible#180 and SynthstromAudible#185 had overlapping changes which were incorrectly resolved in favor of 185 - SynthstromAudible#182 and SynthstromAudible#184 had a conflict which were (mostly correctly) resolved in favour 182, but the new menu entry then got missing. Re implemented it in the new structure.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Revert "Revert "refactor: remove unmaintained code for the 40-pad deluge (#185)"" This reverts commit fb5016a. * fix for merge commits - #180 and #185 had overlapping changes which were incorrectly resolved in favor of 185 - #182 and #184 had a conflict which were (mostly correctly) resolved in favour 182, but the new menu entry then got missing. Re implemented it in the new structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
drawBar()method is moved unmodified fromIntegerContinuoustoNumberas it only depends of attributes of theNumberbase class.I think we eventually should have a unified display that fits both the slider bar and potential decimals on the same screen, but for now it gives you the option of either showing the old stock firmware layout or the one implemented in #17 .