-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve filter processing and clean up API #304
Improve filter processing and clean up API #304
Conversation
b741677
to
bd79526
Compare
Sorry for all the force pushes, I'm bughunting and needed to clean up the commits to be atomic |
Initial tasks are all complete now, but I've found a new one that will be necessary
|
586d030
to
360ec0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks, but at least one (the git conflict) is blocking. Otherwise LGTM.
src/deluge/model/global_effectable/global_effectable_for_clip.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more minor nitpicks but otherwise LGTM. Nice cleanup, thanks!
src/deluge/model/global_effectable/global_effectable_for_clip.cpp
Outdated
Show resolved
Hide resolved
Cool - I'll address those and I think I can move the boiler plate linear to log frequency stuff from the filter implementations to the template as well |
Should be good to go now |
enable lto in relwithdebinfo to stop crash in voice stealing format fix
fix format again
break state into l/r properly store lpfmode
9ec5784
to
1d3ee8a
Compare
aa3d0bc
WIP on #105
Summary: ~10% gain in mono filtering, 60% gain in stereo filtering, much easier API
No audible changes