Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser sorts by folders then files alphabetically #66

Closed
wants to merge 5 commits into from

Conversation

dctucker
Copy link
Contributor

@dctucker dctucker marked this pull request as ready for review June 17, 2023 08:07
src/FileItemArray.h Outdated Show resolved Hide resolved
src/Browser.cpp Outdated Show resolved Hide resolved
Adds a flag to enable the new feature at compile time.
Use CXX_DEFINES+=-DFEATURE_SORT_FOLDERS_FIRST to enable.
@dctucker dctucker marked this pull request as draft June 18, 2023 04:17
@dctucker
Copy link
Contributor Author

I've converted this back to draft because I discovered a bug when loading songs.

@weavermedia
Copy link
Contributor

Could this be a preference in main settings?

@litui litui added the enhancement New feature or request label Jun 22, 2023
@jamiefaye
Copy link
Collaborator

Please fix conflicts.

@m-m-adams m-m-adams added the merge conflict github reports a merge conflict that should be resolved. label Aug 8, 2023
@PaulFreund PaulFreund added the stale PR was not updated in two weeks and will be closed soon. A new PR can be created to pick up the work label Aug 25, 2023
@PaulFreund
Copy link
Collaborator

Hey, a quick heads up :) After two weeks without any activity from the author of a PR we tag it with the "stale" label and close it after another week of inactivity as per our Contributor guidelins. This is not to create pressure or discourage anyone but to keep the list of Pull requests maintainable.

We are very happy about your contribution and nothing will be lost. You can pick up the work at any time by reopening the PR or creating a new one.

@dctucker
Copy link
Contributor Author

Did the bugs related to the file browser ever get squashed? If not, I'll go ahead and close this PR because to me it doesn't make sense to ship an improvement that would only have the effect of adding a variable to an already unstable feature.

@PaulFreund
Copy link
Collaborator

I honestly didn't follow up on that and I think there is no ticket for it. If you have the motivation to find out and update your changes we can reopen the PR :)

@PaulFreund PaulFreund closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merge conflict github reports a merge conflict that should be resolved. stale PR was not updated in two weeks and will be closed soon. A new PR can be created to pick up the work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants