Options button broken in private browsing mode

[hfr-hfr]

When in Firefox's "private mode", toolbar widget is clickable and opens its info window, but:

• "Options" not clickable
• Doesn't show the emulated CDN, although counter indicates action

When in Firefox's "normal mode", the above works as intended.

[Thorin-Oakenpants]

confirmed in FF56. Info not shown (domain, library, whitelisting button). Options button is clickable but does not do anything. Counter increases by 2 on each test (if that's meant to be correct, it also does this in normal windows)

normal windows

private browsing mode

[ghost]

Browser console error that is thrown: (tested on Nightly)

TypeError: popup.backgroundPage is undefined [Learn More] popup.js:351:1

@Thorin-Oakenpants Wow dude, 119269 injected resources ^^

[Kasijjuf]

FWIW, Privacy Badger does a similar thing in Private browsing mode. The list of trackers only shows up on normal mode.

[Synzvato]

Hi everyone, and thanks for sharing your detailed findings and concerns!

As mentioned by @Kasijjuf, any website-specific information is intentionally absent from private browsing mode. This might change in the future. Either way, the options button should not be unresponsive.

I'll dedicate this issue to the underlying bug. Feel free to open up a separate issue, if you are interested in discussing the extension's behavior in private mode. Thanks again! I'll be sure to keep you all posted.

[Synzvato]

Counter increases by 2 on each test ([...], it also does this in normal windows)

@Thorin-Oakenpants This is expected behavior. It's because the testing utility requests the very same resource twice. So, two injections occur, but only one unique resource is injected. Good catch though!

[Synzvato]

Decentraleyes v2.0.1 has since been published. Installing the update should solve the issue.

[Synzvato]

@hfr-hfr @Thorin-Oakenpants I have implemented a messaging system in order to achieve complete feature parity, so v2.0.4 doesn't lack any features when used within Private Browsing contexts.

[Thorin-Oakenpants]

I saw that 👍 .. still increases the count by two (not that it matters) - nvm, that's the test, not PB mode specific :headbutt: