Skip to content
This repository has been archived by the owner on Jun 8, 2018. It is now read-only.

Use a different icon color for whitelisted sites #228

Open
Betsy25 opened this issue Nov 4, 2017 · 3 comments
Open

Use a different icon color for whitelisted sites #228

Betsy25 opened this issue Nov 4, 2017 · 3 comments
Labels

Comments

@Betsy25
Copy link

Betsy25 commented Nov 4, 2017

Right now, people have no direct knowledge to know if Decentraleyes is intervening in a sites used scripts, and are stumped when thing don't work as they normally should. Wouldn't it be easier for users for clearly seeing the difference between a non- and a whitelisted site, for example the currently colored icon for non-whitelisted sites, and a differently colored icon when the site is whitelisted ?

@jonazc
Copy link

jonazc commented Nov 12, 2017

people have no direct knowledge to know if Decentraleyes is intervening in a sites

but they do, when a script is rerouted, there will be a counter shown with the button, do you have the latest version installed?

@Synzvato Synzvato changed the title Good idea to use different toolbar icon color when site is whitelisted ? Use a different icon color for whitelisted sites Nov 19, 2017
@vertigo220
Copy link

Despite the fact there's a badge on the icon, I still think it would be ideal to have the icon change color based on whether it's active or not on the current site. For one, just because it's active doesn't mean it's actually doing anything on that particular page and, inversely, the lack of a badge could mean either that it's active and just not doing anything or that it's disabled. I think it should be orange or yellowish-orange when it's disabled (not red, because it's not necessarily bad that it's disabled, whereas red indicates bad; it may be disabled on purpose, but it would still be good to have the indication in case that was forgotten).

@Thorin-Oakenpants
Copy link

Thorin-Oakenpants commented May 17, 2018

I agree that displaying the whitelist state in the toolbar is a good idea. But I would go even further:

  • [1] If a site does block/replace resource -> the badge counter in green
  • [2] nothing to do -> no badge (current)

Drilling down into [2] above, a subset of whitelisted sites could have two outcomes

  • 2A: still nothing to do -> no badge (current)
  • 2B: something could have been locally injected -> the badge counter in red (new code)

Thus, only whitelisted sites that could have blocked x resources (scenario 2B) would trigger a different visual element. I don't know what that would entail code wise (counting but not executing)

Otherwise. If its too hard to count, then you can't differentiate between the two possible outcomes for whitelisted sites (something locally injected vs not), so you might as well just always display something for whitelisted sites. I would suggest just using the badge with a question mark in it or something

ExE-Boss pushed a commit to EB-Forks/decentraleyes that referenced this issue Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants