Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/constrain enzymes #63

Merged
merged 5 commits into from Dec 12, 2018
Merged

Refactor/constrain enzymes #63

merged 5 commits into from Dec 12, 2018

Conversation

BenjaSanchez
Copy link
Collaborator

  • simplified changeMedia_batch to only open the carbon source exchange rxn. The old function was moved to utilities (changeMedia_yeast)
  • added c_source as input to constrainEnzymes & flexibilizeProteins for making functions more generic
  • added/updated documentation for several functions, partly addressing improve usability #51

simplified changeMedia_batch to only open the carbon source exchange rxn
added c_source as input to constrainEnzymes & flexibilizeProteins for making functions more generic
+ updated readme (changeMedia_batch.m is now optional to modify)
only model change is opening exchange of bicarbonate, which has no effect in the final simulations
@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #63 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #63   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           2        2           
  Lines         185      185           
  Branches       23       23           
=======================================
  Hits          181      181           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf13a30...4cc652e. Read the comment docs.

Copy link
Member

@IVANDOMENZAIN IVANDOMENZAIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to sleep, everything looks good!

@BenjaSanchez BenjaSanchez merged commit 81e9224 into devel Dec 12, 2018
@BenjaSanchez BenjaSanchez deleted the refactor/constrainEnzymes branch December 30, 2018 17:03
@BenjaSanchez BenjaSanchez mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants