Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/yeast compatibility #66

Merged
merged 3 commits into from Jan 7, 2019
Merged

Feat/yeast compatibility #66

merged 3 commits into from Jan 7, 2019

Conversation

BenjaSanchez
Copy link
Collaborator

makes the method backwards compatible with any yeastGEM from 8.0.0 onwards. No model changes to 8.1.3.

* addProteins should be called after addEnzymesToRxn
* changeRxns should be allowed to add new mets at the manualModifications step
Only change pseudoreaction if the model has it
only remove fields that are available in COBRA model
@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #66 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #66   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           2        2           
  Lines         185      185           
  Branches       23       23           
=======================================
  Hits          181      181           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d838d4...d0c91ec. Read the comment docs.

Copy link
Member

@IVANDOMENZAIN IVANDOMENZAIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am convinced that these changes must be approved

@BenjaSanchez BenjaSanchez merged commit 0b14cc3 into devel Jan 7, 2019
@BenjaSanchez BenjaSanchez mentioned this pull request May 1, 2019
@BenjaSanchez BenjaSanchez deleted the feat/yeastCompatibility branch May 1, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants