Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gene essentiality workflow #675

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mihai-sysbio
Copy link
Member

@mihai-sysbio mihai-sysbio commented Jul 7, 2023

Main improvements in this PR:

This PR aims to automatise the gene essentiality checks as introduced in #563 with a GitHub workflow, also discussed in that PR thread.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

- name: Run gene essentiality
id: essentiality
run: |
TEST_RESULTS=$(/usr/local/bin/matlab -nodisplay -nosplash -nodesktop -r "ihuman = importYaml('Human-GEM.yml'); taskStruct = parseTaskList('data/metabolicTasks/metabolicTasks_Essential.txt'); eGenes = estimateEssentialGenes(ihuman, 'Hart2015_RNAseq.txt', taskStruct); disp(evaluateHart2015Essentiality(eGenes));" | awk 'NR>9 && !/^\.+/')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haowang-bioinfo the output of this line is very hard to capture/use. Do you have any suggestions to make this output more compact?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in this workflow run, the output is way too rich to fit in a PR comment. @haowang-bioinfo how would you suggest to change it to end up with a nice summary like here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I've never thought about this. Because they are non-binary indicators that are hard to be used for evaluating purpose in actions

@mihai-sysbio
Copy link
Member Author

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Aug 13, 2023

Also noting here this relevant research article Synthetic lethality in large-scale integrated metabolic and regulatory network models of human cells.

yes, it mentioned another method gMCStool that can predict essential genes in context-specific models.

Other checks than essentiality are also welcome

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This PR has been automatically tested with GH Actions. Here is the output of the gene essentiality test:

 

Note: In the case of multiple test runs, this post will be edited.

@mihai-sysbio mihai-sysbio marked this pull request as ready for review October 6, 2023 11:33
@feiranl
Copy link
Collaborator

feiranl commented Oct 9, 2023

@mihai-sysbio Could you explain the reason for the failing task?

@mihai-sysbio
Copy link
Member Author

@mihai-sysbio Could you explain the reason for the failing task?

The task isn't actually failing, really. As mentioned in the comment above, it's simply that the output of the gene essentiality is so long that it cannot be posted as a PR comment. I couldn't figure out how @haowang-bioinfo ran the calculations to obtain a much more compressed output. As visible in the workflow changes, the code here is just calling functions defined elsewhere.

@haowang-bioinfo
Copy link
Member

I couldn't figure out how @haowang-bioinfo ran the calculations to obtain a much more compressed output. As visible in the workflow changes, the code here is just calling functions defined elsewhere.

the concise output was an outcome of a series of manual operations of running functions, copy/paste results, and modifications with text editor

@mihai-sysbio
Copy link
Member Author

If these last manual steps could be ran as a function, then we would be ready to run the gene essentiality analysis on every PR 💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants