-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Importer to work with new Finding Template API #4
Comments
If we wanted to import a finding in multiple languages we are running into the issue, that we cannot reference the id of a finding. My suggestion is to have something like an "external_reference_id" or similar. This way we can store the original ID from the app X we are importing from. This would also help to have a check, if a template has already been imported or not. Furthermore, we could ask the user to overwrite it or not. |
I see the problem. I suspect that this would be two executions of
Maybe for the sake of simplicity, we import finding templates as they were in the previous application. If Defect Dojo does not support multilanguage finding templates, each finding is imported as a new finding template to SysReptor. This would mean, translations would not be aggregated. If pwndoc-ng supports multilanguage finding templates, we can easily import those findings in one step. What do you think? |
Well, I guess everything comes down to the individual importer. Some applications do not offer multi language. We don't need to worry about them. For the multi language apps, it also comes down to the way they save their multi language findings. However, I think that the finding templates page needs to be reworked a little. For instance, it should be possible to select multiple findings at the same time and delete all selected items. |
Respect new structure
The text was updated successfully, but these errors were encountered: