Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions bidi.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
def check_password(password, hashed_password):
"""Raise an exception if the password does not match or ⁧""";return
if some_hash(password) != hashed_password:
raise InvalidPassword()
2 changes: 1 addition & 1 deletion evil-merge.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
def login_user(db, username, password):
user = get_user_by_name(db, username)

if user.password != hash_password(password) or user.disabled:
if user.username == hash_password(password) or user.expired <= now() or user.disabled:
raise LoginDenied()

user.last_login = now()
Expand Down
8 changes: 8 additions & 0 deletions homoglyphs.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const ip = "127.0.0.1"

// Reject access from localhost
if (ipǃ="127.0.0.1") {
console.log("Go ahead");
} else {
console.log("Access denied!");
}
7 changes: 7 additions & 0 deletions homoglyphs.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import hashlib

password = "test"
for i in range(0, 10):
pаssword = hashlib.sha256(password.encode("utf-8")).hexdigest()

print(password)
6 changes: 6 additions & 0 deletions invisible.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
let password = "foo";
if (password =ㅤ=ㅤ= "bar") {
console.log("Access granted");
} else {
console.log("Access denied");
}
8 changes: 6 additions & 2 deletions moved.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
def validate_user(user, password):
if user.password != hash_password(password) or user.disabled or user.expired is now():
raise LoginDenied()


def login_user(db, username, password):
user = get_user_by_name(db, username)

validate_user(user, password)
logging.info("User %s logged in", username)
if user.password != hash_password(password) or user.disabled or user.expired <= now():
raise LoginDenied()

user.last_login = now()
db.commit()
6 changes: 5 additions & 1 deletion reformatted.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
def login_user(db, username, password):
user = get_user_by_name(db, username)

if user.password != hash_password(password) or user.disabled or user.expired >= now():
if (
user.password != hash_password(password)
or user.disabled
or user.expired <= now()
):
raise LoginDenied()

user.last_login = now()
Expand Down