Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Craftedv2 transition guide #377

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Craftedv2 transition guide #377

merged 4 commits into from
Oct 2, 2023

Conversation

jeffbowman
Copy link
Contributor

Comments or updates?

@sthesing
Copy link
Contributor

sthesing commented Oct 2, 2023

Nope, I think it's fine as it is.

@jeffbowman
Copy link
Contributor Author

If @jvdydev agrees, I'll merge it. Thanks @sthesing for assisting on this! It looks much better than my original attempt.

jvdydev
jvdydev approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jvdydev jvdydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting nit-picks.
Otherwise looks good.

v1tov2transition-guide.md Outdated Show resolved Hide resolved
v1tov2transition-guide.md Outdated Show resolved Hide resolved
v1tov2transition-guide.md Outdated Show resolved Hide resolved
@jeffbowman jeffbowman merged commit 5b7f0db into craftedv2RC1 Oct 2, 2023
@jeffbowman jeffbowman deleted the craftedv2-transition-guide branch October 2, 2023 18:31
@sthesing sthesing mentioned this pull request Oct 6, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdydev jvdydev jvdydev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffbowman @sthesing @jvdydev