added variable to make doom-modeline optional

[erikLundstedt]

this closes issue #44

Signed-off-by: Erik Lundstedt erik@lundstedt.it

[daviwil]

Choice of mode line customization is a pretty big one, on the order of choosing your preferred font and color theme.

I'm starting to wonder if we should configure the mode line somewhere else, like in a separate module that can be included only if you want mode line customizations. That would make it easier to have multiple rational-doom-modeline.el etc configurations which don't require configuration variables to decide whether they're turned on or off.

What do you think?

[erikLundstedt]

Choice of mode line customization is a pretty big one, on the order of choosing your preferred font and color theme.

I'm starting to wonder if we should configure the mode line somewhere else, like in a separate module that can be included only if you want mode line customizations. That would make it easier to have multiple rational-doom-modeline.el etc configurations which don't require configuration variables to decide whether they're turned on or off.

What do you think?

I don't know

I was planning on making a pr with the telephone-line modeline config I've got where you run a function to use different configurations/defaults and the user get to start the modeline themselves as you need to do the config before starting the modeline with telephone-line-mode or something similar

[erikLundstedt]

Choice of mode line customization is a pretty big one, on the order of choosing your preferred font and color theme.

I'm starting to wonder if we should configure the mode line somewhere else, like in a separate module that can be included only if you want mode line customizations. That would make it easier to have multiple rational-doom-modeline.el etc configurations which don't require configuration variables to decide whether they're turned on or off.

What do you think?

Actually
That sounds pretty good
Because then I can write (parts of) the telephone-line module

[bkaestner]

The current commit history is a bit of a mess. While the intend is fine, can you please clean it up? Given the contents of your changes, you could squash them into a single commit.

[bkaestner]

I don't concur with setting a variable that controls an optional feature to t by default.

[erikLundstedt]

I don't concur with setting a variable that controls an optional feature to t by default.

thats to not break existing configs
i could change that i guess

[erikLundstedt]

The current commit history is a bit of a mess. While the intend is fine, can you please clean it up? Given the contents of your changes, you could squash them into a single commit.

I am not sure on how to do that as ive only ever used git(gitlab) for my own code where messy history isnt a problem

[angrybacon]

I am not sure on how to do that as ive only ever used git(gitlab) for my own code where messy history isnt a problem

It is always an issue, it's just that GitHub (and GitLab) will optionally let you squash commits while merging once the PR is accepted. That being said, squashing yourself is the conventional thing to do and it helps codeowners review changes more easily without carrying the minor details we talked about here

To squash your commits into one, you can pull your branch locally as per latest, and if you're using Magit, ri from the status buffer is probably the easiest

[erikLundstedt]

I am not sure on how to do that as ive only ever used git(gitlab) for my own code where messy history isnt a problem

It is always an issue, it's just that GitHub (and GitLab) will optionally let you squash commits while merging once the PR is accepted. That being said, squashing yourself is the conventional thing to do and it helps codeowners review changes more easily without carrying the minor details we talked about here

To squash your commits into one, you can pull your branch locally as per latest, and if you're using Magit, ri from the status buffer is probably the easiest

the thing now is that there have been changes made afterwards

im gonna try