Load theme instead of setting default fg/bg color #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring the default foreground and background color takes extra effort to undo when loading a theme after early-init processes. See Loads the deeper-blue theme as that one is built-in and matches closely the default colors.
daviwil
reviewed
Feb 26, 2022
| (push '(mouse-color . "white") default-frame-alist) | ||
|
|
||
| ;; Loads a nice blue theme, avoids the white screen flash on startup. | ||
| (load-theme 'deeper-blue t) |
There was a problem hiding this comment.
I wonder how well this will work with Emacs running as a daemon?
There was a problem hiding this comment.
Maybe place a guard (test) there and only load when display-graphic-p and/or not daemonp?
There was a problem hiding this comment.
Works fine. I usually run emacs as a deamon and then use emacsclient to start emacs.
There was a problem hiding this comment.
Test it with emacs -nw and emacs-client -t in a terminal emulator should to verify that it works.
Could probably use a customize variable to make it easy to change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the default foreground and background color takes extra
effort to undo when loading a theme after early-init processes. See
#37 for commentary and resolution.
Loads the deeper-blue theme as that one is built-in and matches
closely the default colors.