Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise7 #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Exercise7 #11

wants to merge 4 commits into from

Conversation

SarahLM
Copy link
Contributor

@SarahLM SarahLM commented Jan 29, 2021

finished:
⭐ For instructions in the README.md on how to build your webapp
for production.

⭐ For no changes in "Files Changed" tab of the refactoring from
vue-cli to create-nuxt-app. (See #1 in instructions)

⭐ For
Lighthouse
reporting that your production website is installable as PWA (except
HTTPS).

⭐ For requesting a review and reviewing another team's PR.

Lighthouse result:

pwainstallable

Link to review:
Systems-Development-and-Frameworks/no-js-pls#9 (review)

@SarahLM SarahLM requested review from roschaefer and a team January 29, 2021 01:38
@medizinmensch
Copy link
Contributor

Hi!

I see you followed @roschaefer advice in aiming for the quick points.
I confirm:

⭐ For Lighthouse reporting that your production website is installable as PWA (except HTTPS).
⭐ For requesting a review and reviewing another team's PR.
⭐ For instructions in the README.md on how to build your webapp for production.
⭐ For no changes in "Files Changed" tab of the refactoring from vue-cli to create-nuxt-app. (See #1 in instructions)

That makes 4 ⭐ in total. As you did this alone, this means full points for you @SarahLM .
@Herzogin and @FrauMauz are unrated. Get well soon!

See you!

Get Well

Copy link
Contributor

@medizinmensch medizinmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants