Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest core 7.3 beta #9

Merged
merged 4 commits into from
Apr 29, 2020

Conversation

andreasohlund
Copy link
Collaborator

@andreasohlund andreasohlund commented Nov 25, 2019

This just exposes the fact that core is no longer making the internal NServiceBus.TransportConnectionString type available in the settings so we need to change the reflection to go via the TransportSeam.Settings class instead.

 It_receives_the_message
  No source available
   Duration: 336 ms

  Message: 
    System.Collections.Generic.KeyNotFoundException : The given key (NServiceBus.TransportConnectionString) was not present in the dictionary.
  Stack Trace: 
    SettingsHolder.Get(String key)
    InitializableRawEndpoint.GetConnectionString(TransportDefinition transportDefinition) line 114
    <Initialize>d__1.MoveNext() line 24
    --- End of stack trace from previous location where exception was thrown ---
 

@SzymonPobiega
Copy link
Owner

Thanks @andreasohlund . The sad fact of life is the more NSB gets componentized, the more things will be not possible in Raw and will have to by monkey patched via reflection. The only long-term solution is to take into account the need to run a transport without going though the full NSB core.

@andreasohlund
Copy link
Collaborator Author

Agreed!

@andreasohlund andreasohlund changed the title [WIP]Update to latest core 7.3 beta Update to latest core 7.3 beta Apr 29, 2020
@andreasohlund
Copy link
Collaborator Author

@SzymonPobiega I've made some changes and i can get MSMQ and learning transport ATTs to pass locally. Can you take a look?

@SzymonPobiega
Copy link
Owner

@andreasohlund I'll merge it and run the tests locally.

@SzymonPobiega SzymonPobiega merged commit a02b0da into SzymonPobiega:master Apr 29, 2020
@SzymonPobiega
Copy link
Owner

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants