Use cStringIO as default but keep StringIO as optional #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for help, chew. I'm currently a bit busy. I'll check and merge you request in meantime. |
chfw
added a commit
to pyexcel/pyexcel-io
that referenced
this pull request
Jul 8, 2016
|
Time flies. It's now 2017. Happy new year! Any plan to merge my PR? |
|
Thank you! Sorry for long response time. |
|
Cheers! Looking forward to its next pypi release. |
This was referenced Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was claimed that cStringIO is faster than StringIO. Hence it would be beneficial to use cStringIO as default and keep StringIO as optional for the freedom of developer.
3 extra test cases was created under Python 2.x in order to test both StringIO and cStringIO in this PR.