Skip to content

Commit

Permalink
[BUGFIX] Subclassing as return value not compatible with PHP7.2
Browse files Browse the repository at this point in the history
Need to return the abstract class instead of the implementational class

Related: #396
Release: 8.0.0
  • Loading branch information
opi99 committed Jun 20, 2022
1 parent 888802f commit 5635068
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Expand Up @@ -25,7 +25,7 @@ class BackendLayoutConfigurationHandler extends AbstractConfigurationHandler
{
public static $identifier = 'TVP\ConfigurationHandler\BackendLayoutConfiguration';

public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): BackendLayoutConfiguration
public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): AbstractConfiguration
{
$backendLayoutConfiguration = new BackendLayoutConfiguration($identifier, $this->place, $this, $file);

Expand Down
2 changes: 1 addition & 1 deletion Classes/Handler/Configuration/DataConfigurationHandler.php
Expand Up @@ -25,7 +25,7 @@ class DataConfigurationHandler extends AbstractConfigurationHandler
{
public static $identifier = 'TVP\ConfigurationHandler\DataConfiguration';

public function createConfigurationFromConfigurationArray(array $dataStructure, string $identifier, SplFileInfo $file): DataConfiguration
public function createConfigurationFromConfigurationArray(array $dataStructure, string $identifier, SplFileInfo $file): AbstractConfiguration
{
$dataConfiguration = new DataConfiguration($identifier, $this->place, $this, $file);

Expand Down
Expand Up @@ -25,7 +25,7 @@ class MappingConfigurationHandler extends AbstractConfigurationHandler
{
public static $identifier = 'TVP\ConfigurationHandler\MappingConfiguration';

public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): MappingConfiguration
public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): AbstractConfiguration
{
$mappingConfiguration = new MappingConfiguration($identifier, $this->place, $this, $file);

Expand Down
Expand Up @@ -25,7 +25,7 @@ class TemplateConfigurationHandler extends AbstractConfigurationHandler
{
public static $identifier = 'TVP\ConfigurationHandler\TemplateConfiguration';

public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): TemplateConfiguration
public function createConfigurationFromConfigurationArray(array $configuration, string $identifier, SplFileInfo $file): AbstractConfiguration
{
$templateConfiguration = new TemplateConfiguration($identifier, $this->place, $this, $file);

Expand Down

0 comments on commit 5635068

Please sign in to comment.