[BUGFIX] Replace NullSite with PseudoSiteFinder #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@opi99 It is worth noting that I am trying out the v8 beta and got the same error - implementing the fix resolved the issue |
|
It is never worth to mention something ... but while reading your note I got the feeling that it is also needed there. ;) |
|
Please, can you update your commit message and prefix the header with [BUGFIX] and add the following lines to the end? (Like it is on most other messages) Resolves: #321 |
NullSite was failing as it was missing the `use` statement at the top. This replaces NullSite with using the PseudoSiteFinder as it returns a more robust "site" instance - as used in the core SiteMatcher class in the `matchByPageId` method Resolves: T3Voila#321 Releases: 8.0.0 7.3.6
|
Sorry @opi99, missed your comment. Have updated the commit 👍 |
opi99
approved these changes
Nov 22, 2021
opi99
pushed a commit
that referenced
this pull request
Nov 22, 2021
NullSite was failing as it was missing the `use` statement at the top. This replaces NullSite with using the PseudoSiteFinder as it returns a more robust "site" instance - as used in the core SiteMatcher class in the `matchByPageId` method Resolves: #321 Releases: 8.0.0 7.3.6
|
Hey @opi99 - is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullSite was failing as it was missing the
usestatement at the top.This replaces NullSite with using the PseudoSiteFinder as it returns a
more robust "site" instance - as used in the core SiteMatcher class in
the
matchByPageIdmethod