[FEATURE] allow PageTSconfig option to filter for mappings #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow easier supplying of sitepackages, as you can filter mappings by page branch easily. Most template extension will provide mappings as well as PageTSconfig, so with this you can easily do a mod.web_txtemplavoilaplusLayout.filterMaps = vendor/yourextension to not show other mappings in that branch. Thus allowing multi-template-setups easily, while still retaining the access check and thus allowing editors for different templates to not mix them up, as we can now filter by page tree as well as user. As there might be extension supplying FCEs only (e.g. bootstrap style containers). there is an option to define an array of allowed stuff like mod.web_txtemplavoilaplusLayout.filterMaps.1 = vendor/yourextension/Page mod.web_txtemplavoilaplusLayout.filterMaps.2 = vendor/yourotherextension/FCE
opi99
requested changes
Apr 22, 2022
opi99
approved these changes
May 3, 2022
jpmschuler
added a commit
to jpmschuler/templavoilaplus
that referenced
this pull request
Oct 12, 2022
…ldn't filter wizards T3Voila#339 introduce map filtering, that was respected in TCA/TCEForm quite fine, but the newCeWizard tab FCE doesn't respect it. Additionally the old option to use `mod.wizards.newContentElement.wizardItems.fce.show = *` or `mod.wizards.newContentElement.wizardItems.fce.show = fce_<identifierA>,fce_<identifierB>` was missing to slim the entries in the tab to have any control on this. This would again allow to hide the tab, e.g. via `mod.wizards.newContentElement.wizardItems.fce.show = none` (as 'none' is a non-existing element)
jpmschuler
added a commit
to jpmschuler/templavoilaplus
that referenced
this pull request
Oct 12, 2022
…ldn't filter wizards T3Voila#339 introduce map filtering, that was respected in TCA/TCEForm quite fine, but the newCeWizard tab FCE doesn't respect it. Additionally the old option to use `mod.wizards.newContentElement.wizardItems.fce.show = *` or `mod.wizards.newContentElement.wizardItems.fce.show = fce_<identifierA>,fce_<identifierB>` was missing to slim the entries in the tab to have any control on this. This would again allow to hide the tab, e.g. via `mod.wizards.newContentElement.wizardItems.fce.show = none` (as 'none' is a non-existing element)
jpmschuler
added a commit
to jpmschuler/templavoilaplus
that referenced
this pull request
Oct 15, 2022
…ldn't filter wizards T3Voila#339 introduce map filtering, that was respected in TCA/TCEForm quite fine, but the newCeWizard tab FCE doesn't respect it. Additionally the old option to use `mod.wizards.newContentElement.wizardItems.fce.show = *` or `mod.wizards.newContentElement.wizardItems.fce.show = fce_<identifierA>,fce_<identifierB>` was missing to slim the entries in the tab to have any control on this. This would again allow to hide the tab, e.g. via `mod.wizards.newContentElement.wizardItems.fce.show = none` (as 'none' is a non-existing element)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow easier supplying of sitepackages, as you can filter
mappings by page branch easily. Most template extension will provide
mappings as well as PageTSconfig, so with this you can easily do a
mod.web_txtemplavoilaplusLayout.filterMaps = vendor/yourextension
to not show other mappings in that branch. Thus allowing
multi-template-setups easily, while still retaining the access check
and thus allowing editors for different templates to not mix them up,
as we can now filter by page tree as well as user.
As there might be extension supplying FCEs only (e.g. bootstrap style
containers). there is an option to define an array of allowed stuff
like
mod.web_txtemplavoilaplusLayout.filterMaps.1 = vendor/yourextension/Page
mod.web_txtemplavoilaplusLayout.filterMaps.2 = vendor/yourotherextension/FCE