Linux fixes #1
Linux fixes #1
Conversation
|
Hey Vincent - this repo was just a mirror of the original SVN repo on SF. I'm not planning to maintain the project. But since the upstream is frozen for a long time, I'd like merge some compatible improvements to make it easier for community to use (like this PR). |
.gitignore
Outdated
| @@ -0,0 +1,10 @@ | |||
| **/*.in | |||
There was a problem hiding this comment.
Usually .in files are use for generating some other files. I don't think we should ignore them.
There was a problem hiding this comment.
These files are autogenerated from Makefile.am files. They should not be commited in a repository.
There was a problem hiding this comment.
$ find . -name "*.in"
./ta-lib.dpkg.in
./ta-lib.pc.in
./ta-lib.spec.in
What about these files?
There was a problem hiding this comment.
Fixed (and improved, now ignoring all generated files).
.gitignore
Outdated
| @@ -0,0 +1,10 @@ | |||
| **/*.in | |||
| **/*.o | |||
There was a problem hiding this comment.
I think *.o is enough if you want to ignore all .o files in the repo. The same to the other lines in the file.
.gitignore
Outdated
| **/*.o | ||
| **/*.lo | ||
| **/*.la | ||
| **/Makefile |
There was a problem hiding this comment.
There're several Makefiles in the repo, which is generated using tmake. I'd like to remove them and add this line if all existed Makefiles can be generated from the source (make/gen_make/). Otherwise I'd prefer to remove Makefile here.
|
|
||
| sprintf( buffer, TA_MCPP_EXE " -@compat -+ -z -P -I.." TA_FS_SLASH "src" TA_FS_SLASH "ta_common -I.." TA_FS_SLASH "src" TA_FS_SLASH "ta_abstract -I.." TA_FS_SLASH "include -D _JAVA .." TA_FS_SLASH "temp" TA_FS_SLASH "CoreJavaCode1.tmp | sed '/^#include/d' > .." TA_FS_SLASH "temp" TA_FS_SLASH "CoreJavaCode2.tmp " ); | ||
| system( buffer ); | ||
| ret = system( buffer ); |
There was a problem hiding this comment.
Why adding the ret? I think it's never used.
There was a problem hiding this comment.
I think it was triggering a warning (possibly error) in my machine. I remember thinking that it was indeed useless.
| all-local: | ||
| $(MAKE) $(AM_MAKEFLAGS) gen_code | ||
| cp gen_code ../../../bin | ||
| # all-local: |
There was a problem hiding this comment.
I'd prefer to leave it unchanged. Is it possible to not install the gen_code script in the PKGBUILD?
There was a problem hiding this comment.
This was triggering a recursive make that was screwing up the compilation when using parallel compilation.
|
Thanks @vbmithr ! |
I fixed the build under Linux (modernized the autoconf files a bit), and added a pkg-config file.
Archlinux package here: https://aur.archlinux.org/packages/ta-lib-git/
Since there are a lot of space changes in the PR, to make it easier to review, the following way is suggested.