Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering for some multisided blocks #7

Merged
merged 2 commits into from
May 28, 2021
Merged

Fix rendering for some multisided blocks #7

merged 2 commits into from
May 28, 2021

Conversation

Arctcc
Copy link

@Arctcc Arctcc commented May 27, 2021

Fixes rendering for blocks that have a top image and a side image. Doesn't fix blocks that have more than two images per block.

Should fix rendering some multisided blocks
@TABmk
Copy link
Owner

TABmk commented May 28, 2021

Hi. First of all, thank you for contributing!
Maybe, we can save the renderSides option for rendering separate images for each sprite. Not sure that it can be useful, but it has already done.

I'll save the renderSides as is and move your code to the main render (without options).
I think no-options-render in the future must render blocks like in-game icons and we can move in this direction.

@TABmk TABmk changed the base branch from master to sides-render-for-no-option May 28, 2021 15:20
@TABmk TABmk merged commit 89fc7e3 into TABmk:sides-render-for-no-option May 28, 2021
@TABmk
Copy link
Owner

TABmk commented May 28, 2021

Created a new branch atm, while I'm trying to understand how to move it outside renderSides

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants