-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DES-2182: Questionnaire asset type #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
Should we merge to a feature branch where subsequent questionnaire work be added to?
Also for this PR or a follow on:
- could unit tests (a simple rq fixture) be added?
- consider rely on the file and not add the rq to the properties.
I left some suggestions on our shared channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💯
just left one required change to a unit test and then potentially something to update in the kube config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
Overview:
Add RAPP questionnaire file (
.rq
) as an importable asset type.PR Status:
Related Jira tickets:
Summary of Changes:
Added questionnaire asset type (panel icon, allowed assets).
Added questionnaire viewer.
Testing Steps:
.rq
file from test projectNotes:
Concerns:
::ng-host
to properly display thequestionnaireBuilder.css
code (globally accessible css)