Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DES-2182: Questionnaire asset type #112

Merged
merged 10 commits into from
May 5, 2023

Conversation

duckonomy
Copy link
Contributor

Overview:

Add RAPP questionnaire file (.rq) as an importable asset type.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added questionnaire asset type (panel icon, allowed assets).
Added questionnaire viewer.

Testing Steps:

  1. Run related geoapi DES-2182: Questionnaire viewer hazmapper#118
    1. Import .rq file from test project
  2. Ensure that questionnaire assets display properly in asset panel
  3. Ensure that questionnaire viewer renders properly.

Notes:

Concerns:

  1. The questionnaire viewer code provided by RAPID team was tightly coupled with the render code, which uses jquery. So I had jquery installed for now. But am still tryiing to look for options to isolate jquery.
  2. Used ::ng-host to properly display the questionnaireBuilder.css code (globally accessible css)

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

Should we merge to a feature branch where subsequent questionnaire work be added to?

Also for this PR or a follow on:

  • could unit tests (a simple rq fixture) be added?
  • consider rely on the file and not add the rq to the properties.

geoapi/services/features.py Show resolved Hide resolved
geoapi/services/features.py Outdated Show resolved Hide resolved
@nathanfranklin
Copy link
Collaborator

I left some suggestions on our shared channel.

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

just left one required change to a unit test and then potentially something to update in the kube config.

geoapi/tests/api_tests/test_feature_service.py Outdated Show resolved Hide resolved
conf/nginx.conf Show resolved Hide resolved
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

duckonomy and others added 2 commits April 26, 2023 06:00
Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
@nathanfranklin nathanfranklin merged commit 69f49ce into master May 5, 2023
3 checks passed
@nathanfranklin nathanfranklin deleted the task/DES-2182-questionnaire-viewer branch May 5, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants