Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-121: migrate to database VM #132

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Aug 1, 2023

Overview:

This PR migrates to database VM:

  • removes db service/app and related DB volumes from kubernetes (i.e. all changes in kube/)
  • adds files for geoapi-database (i.e. docker compose yml, postgress settings, readme, makefile which are all in devops/databae)

PR Status:

  • Ready.

Related Jira tickets:

Notes:

I also put a top-level README in ~portal/ on geoapi-database VM:

portal@geoapi-database:~$ ls -l
total 12
-rw-rw-r--  1 portal portal  199 Aug 11 14:39 README.txt
drwxrwxr-x 10 portal portal 4096 Aug 11 14:39 geoapi
-rw-rw-r--  1 portal portal   62 Aug  1 10:58 secret.env

@nathanfranklin nathanfranklin marked this pull request as draft August 1, 2023 20:40
@nathanfranklin nathanfranklin marked this pull request as ready for review August 11, 2023 19:37
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - pinged db within container. LGTM!

- name: DB_PASSWD
valueFrom:
secretKeyRef:
name: postgres
name: postgres-vm
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taoteg. fyi. in the services in kube that access the database, we have secrets/env-variables for database access. the previous secrets were stored under the name postgres in kube but @sophia-massie and I save the new ones under postgres-vm to not override the old ones. so we keep temporarily the old ones that work for the kube db and then also have the new ones that work for the new db vm.

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanfranklin nathanfranklin merged commit cd08167 into master Aug 14, 2023
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-121-move-to-db-vm branch August 14, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants