Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-130: Add missing rollback in case of failed database connection #136

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

Add missing rollback in case of a failed database connection occurs when getting list of observable projects

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. one could add a raise Exception()
  2. and then alter geoapi/celery_app.py so the refresh task occurs every minute
  3. then confirm things in local logs'

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as remembered).

@nathanfranklin nathanfranklin merged commit 6e2cc6c into master Aug 25, 2023
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-130-fix-datbase-rollback-issue branch August 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants