Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-170: fix scraping of questionnaire #152

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Oct 25, 2023

Overview:

This PR adds support the scraping of questionnaires. It ensures the questionnaires in connected projects are scraped and that any asset images aren't inadvertently scrapped twice.

This PR also:

  • refactors how we determine which files to scrape
  • removes audio file formats that were not used

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. Use hazmapper's feature/questionnaire when running hazmapper
  2. Create a new map and select top level dir of shared project "Questionnaire_Example". ensure "Sync Folder" is checked. (See screenshot below)
  3. Click "Submit"
  4. See that one questionnaire is imported correctly. and that its asset images aren't incorrectly imported as individual assets.
  5. Note that there will be some log errors as there are some questionnaire files in the /Rapp folder that do not have a geolocation. I can remove those if we want a cleaner project to test thing with.

Screenshot 2023-10-26 at 4 40 52 PM

@nathanfranklin nathanfranklin changed the base branch from master to feature/questionnaire October 25, 2023 20:47
@nathanfranklin nathanfranklin self-assigned this Nov 1, 2023
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this refactor! LGTM

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Definitely cleaner after the refactor. LGTM!

geoapi/services/features.py Outdated Show resolved Hide resolved
@nathanfranklin nathanfranklin merged commit e4b2e6f into feature/questionnaire Nov 3, 2023
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-170-fix-scraping-of-questionnaire branch November 3, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants