Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WG-212: improve projects endpoint #173

Merged
merged 26 commits into from
Feb 20, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Jan 16, 2024

Overview:

The Hazmapper client does the following when creating a project:

  • A) request to geoapi to create a map project
  • B) request to Tapis to write a file and delete file (i.e. .hazmapper)
  • C) request to Tapis (which gets passed onto DesignSafe) to update metadata for the project
  • D) creates 2 default tile layers

This PR:

  • Refactors the payload for the create project route
  • Fixes issues when determining admin and creator status after project is created
  • Moves (B) to backend
  • Moves (C) to backend
  • Moves (D) to backend

and Hazmapper is updated in TACC-Cloud/hazmapper#199

Related Jira tickets:

Testing Steps:

  1. Run this locally
  2. Test with task/WG-212: use updated project create and project update routes hazmapper#199 (Angular code so cd angular, use the correct node version and npm run start).
  3. Create new map projects
  4. Ensure that two base layers are created by default
  5. Ensure that a .hazmpapper file is created
  6. if connected to a DS project, ensure that the metadata for that DS project has been updated.

Notes:

@nathanfranklin nathanfranklin marked this pull request as draft January 16, 2024 22:53
@nathanfranklin nathanfranklin marked this pull request as ready for review February 6, 2024 01:13
Copy link
Contributor

@tjgrafft tjgrafft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally with the frontend (angular-hazmapper) and everything worked, as expected.

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally - see the appropriate logs for creating and deleting map projects. DS meta data also is appearing as expected when map project is associated with a DS project

@nathanfranklin nathanfranklin merged commit ca1b178 into master Feb 20, 2024
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-212-improve-projects-endpoint branch February 20, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants