Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ecep_cms #184

Merged
merged 19 commits into from
Sep 1, 2023
Merged

feat: ecep_cms #184

merged 19 commits into from
Sep 1, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 18, 2023

Overview

Migrate project from Core-CMS-Resources.

Important
Delete the "CSS: Site" snippet (pprd, prod) to remove the "Template ecep-cms/templates/snippets/site-css.html does not exist." error from the footer.

Screenshot snippet error message

Related

Testing

  1. Verify deploy succeed. (https://pprd.ecep.tacc.utexas.edu/)
  2. Verify custom CSS loads. (It gives purple header and links.)

UI

Many Screenshots
  • version
  • home top
  • home bottom 👆 To remove the error at bottom of footer, delete that snippet. 👆
  • alliance-members
  • news list
  • news page
  • resources
  • publications

@wesleyboar wesleyboar marked this pull request as draft July 18, 2023 15:38
@wesleyboar wesleyboar marked this pull request as ready for review August 30, 2023 21:26
@wesleyboar wesleyboar requested review from taoteg and removed request for taoteg August 30, 2023 21:27
@wesleyboar wesleyboar marked this pull request as draft August 30, 2023 21:30
@wesleyboar wesleyboar marked this pull request as ready for review August 30, 2023 22:55
@wesleyboar wesleyboar requested a review from taoteg August 31, 2023 18:22
ecep_cms/README.md Outdated Show resolved Hide resolved
ecep_cms/elasticsearch.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing here that is technically incorrect, all working fine. All my comments are based on consistency of organization across the projects. Take them with three grains of salt from the table of Marie Kondo...

@wesleyboar wesleyboar merged commit 2bcadc0 into main Sep 1, 2023
1 check passed
@wesleyboar wesleyboar deleted the task/migrate-ecep branch September 1, 2023 20:46
@wesleyboar
Copy link
Member Author

wesleyboar commented Sep 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants