Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101: Branding Bar #220

Merged
merged 2 commits into from May 13, 2021
Merged

GH-101: Branding Bar #220

merged 2 commits into from May 13, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 11, 2021 •
edited

Overview

Redesign the branding bar.

Issue

GH-101

Changes

  • Migrate branding_logos CSS to c-branding & c-logo.
  • In s-header style .c-logo not .navbar-brand.
  • Update and format markup for header_branding and header_logo.
  • Comment on now-unused secrets values.

Testing

  1. Build CSS.
  2. Load site (with page wider than 576px).
  3. Confirm branding bar matches CMS-Common Components > Brand-Bar.
  4. Resize page to narrow than 576px.
  5. Confirm gap between columns is reduced.

@wesleyboar wesleyboar changed the base branch from main to task/GH-101-header-redesign May 11, 2021 15:45
@wesleyboar wesleyboar mentioned this pull request May 11, 2021
Closed
@wesleyboar
GH-101: Branding Bar
3e4a501 
- Migrate `branding_logos` CSS to `c-branding` & `c-logo`.
- In `s-header` style `.c-logo` not `.navbar-brand`.
- Update and format markup for `header_branding` and `header_logo`.
- Comment on now-unused secrets values.
@wesleyboar wesleyboar force-pushed the task/GH-101-header-redesign--branding-bar branch from 7b1a8cb to 3e4a501 Compare May 11, 2021 15:50
@wesleyboar wesleyboar mentioned this pull request May 12, 2021
Draft
26 tasks
@wesleyboar wesleyboar closed this May 12, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--branding-bar branch May 12, 2021 22:00
@wesleyboar wesleyboar restored the task/GH-101-header-redesign--branding-bar branch May 13, 2021 02:13
@wesleyboar wesleyboar reopened this May 13, 2021
@wesleyboar wesleyboar merged commit 80ed3c0 into task/GH-101-header-redesign May 13, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--branding-bar branch May 13, 2021 02:18
This was linked to issues May 13, 2021
Header Redesign → FP-1458 #101
Closed
Resize "Brand Bar" and "Nav Bar" #29
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458 Resize "Brand Bar" and "Nav Bar"
1 participant
@wesleyboar