Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-101: Portal Nav (Load with Transition / Animation) #237

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 28, 2021

Overview

Load portal nav with no width, then transition it to "natural" width.

The login icon has not been restyled yet. The location of portal nav in mobile has not moved, yet.

Issues

Changes

  • Minor: Add missing specificity to a Portal Nav selector.
  • New: Make Portal Nav gently pushnot abruptly shove—Search Bar aside after it loads.

Testing

  1. Load CMS.
  2. Ensure Portal Nav gently pushed search to the left.
  3. Load Docs.
  4. Ensure Portal Nav gently pushed search to the left.
  5. Load Portal.
  6. Ensure Portal Nav loads before search i.e. search is not pushed anywhere.

Notes

Known Issue

  1. Does not work on Docs unless Docs has (commits from) branch task/GH-101-header-redesign.
  2. (pre-existing defect) The width of Portal Nav on CMS & Docs differs from Portal (may be related to font size of whitespace).

Load the portal nav into place, then transition it into normal width.

Give sidebar gentle push—not abruptly shove—when portal nav loads.
@wesleyboar wesleyboar changed the title GH-101: Quick: Fix unrealized specificity bug GH-101: Portal Nav (Load with Transition / Animation) May 28, 2021
Migrate the new code of the previous commits to a stylesheet, so Docs can load it.
@wesleyboar wesleyboar merged commit 6776560 into task/GH-101-header-redesign May 28, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--portal-nav-load-transition branch May 28, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant