Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-101: Cleanup #242

Merged

Conversation

wesleyboar
Copy link
Member

Overview

  • Refactor related styles.
  • Fix easy Docs & Portal bugs.

Issues

Changes

  • New: Migrate s-header-….css into to s-header.css.
  • Minor: Clearer comment in c-branding.
  • Minor: Migrate style specific to tacc-search-bar to its CSS file.
  • Fix: Resolve Docs bugs (caused by outdated Docs styles).
  • Minor: Clearer comments in s-cms-nav.
  • New: Refactor s-header.css.
  • Minor: Clearer comments in s-portal-nav.

Testing

Everything should work as it did in target branch, or better.

- __New__: Migrate `s-header-….css` into to `s-header.css`.
- _Minor_: Clearer comment in `c-branding`.
- _Minor_: Migrate style specific to `tacc-search-bar` to its CSS file.
- __Fix__: Resolve Docs bugs (caused by outdated Docs styles).
- _Minor_: Clearer comments in `s-cms-nav`.
- __New__: Refactor `s-header.css`.
- _Minor_: Clearer comments in `s-portal-nav`.
@wesleyboar wesleyboar self-assigned this Jun 3, 2021
@wesleyboar wesleyboar linked an issue Jun 3, 2021 that may be closed by this pull request
@wesleyboar wesleyboar merged commit ec99140 into task/GH-101-header-redesign Jun 3, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--cleanup branch June 3, 2021 07:23
@wesleyboar wesleyboar mentioned this pull request Jun 3, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458
1 participant