Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101: Search #244

Merged
merged 2 commits into from Jun 4, 2021
Merged

GH-101: Search #244

merged 2 commits into from Jun 4, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jun 3, 2021 •
edited

Overview

  • Refactor search bar.
  • Redesign search bar.
  • Remove "freeze variables".

Warning: Not tested on Frontera, yet. (Should be able to remove Frontera-specific stylesheet.)

Changes

  • Fix: Remove "freeze variables".
  • New: Remove old, bad search styles.
  • New: Add new, good search styles.
  • Minor: Remove beginner comments about position: relative.
  • New: Add new utility for hiding elements.
  • New: Add new theme/env vars for search border and background.
  • Fix: Simplify search field markup.

Testing

  • match design (with known deviations)
  • search bar on site with light theme uses light colors that match design (with known deviations)
  • search bar on page using frontera template does not differ from other templates

Notes

Known Deviations from Design

  1. Search Bar height is shorter in mobile nav because mobile nav height is shorter.

  2. Search Bar colors may use a standard color instead of the color in design doc.

    Is that allowed?

    Yes. I have prior private permission to make these "fixes" during translation. I plan (eventually) to teach Portal devs how to do the same.

@wesleyboar
GH-101: Search (Initial Commit)
faab92b 
WARNING: Not tested on light theme, yet.

- __Fix__: Remove "freeze variables".
- __New__: Remove old, bad search styles.
- __New__: Add new, good search styles.
- _Minor_: Remove beginner comments about `position: relative`.
- __New__: Add new utility for hiding elements.
- __New__: Add new theme/env vars for search border and background.
- __Fix__: Simplify search field markup.
@wesleyboar wesleyboar mentioned this pull request Jun 3, 2021
Draft
26 tasks
@wesleyboar
GH-101: Search (Frontera Cleanup)
4b0fbe8 
Remove Frontera styles that are no longer necessary.
@wesleyboar wesleyboar linked an issue Jun 4, 2021 that may be closed by this pull request
Header Redesign → FP-1458 #101
Closed
@wesleyboar wesleyboar marked this pull request as ready for review June 4, 2021 04:26
@wesleyboar wesleyboar merged commit ab6d670 into task/GH-101-header-redesign Jun 4, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--search-bar branch June 4, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458
1 participant
@wesleyboar