GH-101: Bug Fixes #248
Merged
GH-101: Bug Fixes #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docs nav was covering the Header nav because of its z-index. Older use of z-index required excess application and values. Since browsers agreed on stacking context, z-index usage is simplified.
Explanation: - The selector `.s-header:not(.is-on-portal)` failed. - Because It affected Portal & Docs, which lack `.is-on-portal`. - It must be limited to CMS (until Portal & Docs have `.is-on-portal`). Other Changes: - Improved related comments. - Added and used `--nav-x-wide-and-...` custom media queries.
- _Minor_: Define variable (even if its absense breaks nothing). - __Fix__: Remove effort to half-match design. - _Minor_: Accept and note the deviation above.
- __Fix__: Spacing values were wrong. - _Minor_: Reorganized Dropdown styles to mirror Nav style organization.
- __Fix__: No background color for shown nav item dropdown. - _Minor_: Add missing comments for "Nav Link: State: Mobile/Desktop".
- __Fix__: Make this spacing more match design. - __New__: Propogate constant renames and use new constants. - __New__: Distinguish `--header-navbar-...-pad` for mobile & normal.
- __New__: Add CSS nesting support. - __New__: Add CSS nesting test case. - __Fix__: Darken background for browsers that cannot blur yet. - _MInor_: Fix other `backdrop-filter` instances.
wesleyboar
changed the title
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix misc. bugs with new header.
Changes
Testing