Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1318: Create Section Pattern via Style Plugin #430

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 18, 2022

Overview

Quickly create existing TACC Section pattern via already-installed Django Style plugin.

CMS Admin/Designer has approved (via private review), but implementation should have dev review.

Tickets

Changes

To our default settings:

  • Add DJANGOCMS_STYLE_CHOICES (docs).
    • to allow user to quickly create light Section or dark Section
  • Add DJANGOCMS_STYLE_TAGS (docs).

Screenshots

⚠️ This video shows more class choices, because it includes #419 also.

FP-1318.Section.Pattern.via.Style.Plugin.mov

Testing

local: instructions
remote: https://dev.cep.tacc.utexas.edu/ (build, deploy)

  1. On any page, create a Style plugin.
  2. Choose CLASS NAME o-section o-section--style-dark.
  3. Confirm dark Section is added.*
  4. Choose CLASS NAME o-section o-section--style-light.
  5. Confirm light Section is added.*

* You may confirm that the markup of the element added has the classname chosen. To see what the section should look like, compare to manual pattern library.

Notes

Related PRs

@wesleyboar wesleyboar mentioned this pull request Jan 18, 2022
4 tasks
@wesleyboar wesleyboar merged commit 929dc4b into main Feb 2, 2022
@wesleyboar wesleyboar deleted the task/FP-1318-section-pattern-as-style-plugin-shortcut branch February 2, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alternative Alternative solution(s) exist(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants