Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSS from Core-Styles & Frontera #518

Closed
wants to merge 3 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 22, 2022

Status

Warning
The TACC/Core-CMS-Resources main branch has changed drastically since the work was started. Resolving merge conflicts in TACC/Core-CMS-Resources#153 may be difficult.

Overview

Add CMS stylesheets that Frontera used, and update Frontera to use them from CMS instead.

Why?

  1. Non-Core CMS's may not have build process in the future.
    • So what they use must come from Core-CMS.
  2. Adapting to the above reason simplifies the CSS of non-Core CMS's.

Related

Changes

  • Bring back CMS-specific stylesheets from Core-Styles.
  • Promote Frontera-style homepage styles from Frontera to CMS.
  • Simplify Frontera stylesheets.

Testing

Build the CMS with https://github.com/TACC/tup-cms/pull/3.

No need for git submodule commands. No need to symlink Frontera settings_custom.py.

Screenshots

(skipped)

Why?

1. Non-Core CMS's may not have build process in the future.
    - So what they use must come from Core-CMS.
2. Adapting to #1 simplifies the CSS of non-Core CMS's.
@wesleyboar wesleyboar added the paused Started but not actively in progress label Jul 22, 2022
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Jul 22, 2022
Core-CMS 'task/TUP-250--frontera-cms-test':
- moved to Core-CMS
- loaded from there by Frontera

caused by TACC/Core-CMS#518
@wesleyboar wesleyboar closed this Mar 25, 2024
@wesleyboar wesleyboar deleted the task/TUP-250--frontera-cms-test branch March 25, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paused Started but not actively in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant