Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMD-72: All CMS Forms Should Send Confirmation E-Mail #817

Merged
merged 12 commits into from
Mar 19, 2024
Merged

CMD-72: All CMS Forms Should Send Confirmation E-Mail #817

merged 12 commits into from
Mar 19, 2024

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

Overview

Sending confirmation email when provided in a form

Related

CMD-72

Changes

Sends a confirmation email when provided in a form.

Testing

  1. Add a new form with an email field
  2. Open Docker image
  3. Check that log contains two emails when provided in the form

UI

Sent Email Confirmation Email
Screenshot 2024-03-15 at 10 15 27 AM Screenshot 2024-03-15 at 10 15 41 AM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added the effort S Small effort task (~½ a week) — does not include review time label Mar 15, 2024
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Mar 15, 2024
wesleyboar
wesleyboar reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Great. Some tweaks necessary before this feature can serve TACC properly.

apps/email_management/apps.py Show resolved Hide resolved
apps/email_management/apps.py Outdated Show resolved Hide resolved
taccsite_cms/settings.py Show resolved Hide resolved
@R-Tomas-Gonzalez
Copy link
Collaborator Author

Sent Email Confirmation Email
Screenshot 2024-03-18 at 7 40 31 AM Screenshot 2024-03-18 at 7 40 10 AM

wesleyboar
wesleyboar reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I will test how the e-mail one renders [in a mail client] (whether it has indentation from spaces or not).

apps/email_management/apps.py Outdated Show resolved Hide resolved
apps/email_management/apps.py Outdated Show resolved Hide resolved
taccsite_cms/settings.py Show resolved Hide resolved
@wesleyboar wesleyboar mentioned this pull request Mar 18, 2024
Closed
wesleyboar
wesleyboar approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Two requests.

apps/email_management/apps.py Outdated Show resolved Hide resolved
apps/email_management/apps.py Outdated Show resolved Hide resolved
@wesleyboar
Copy link
Member

wesleyboar commented Mar 18, 2024 •
edited

P.S. I tested this with real e-mail from TUP dev via TACC/tup-ui#444 & TACC/tup-ui#v1.1.8-202403-06.

@R-Tomas-Gonzalez R-Tomas-Gonzalez merged commit 0a193ef into main Mar 19, 2024
@R-Tomas-Gonzalez R-Tomas-Gonzalez deleted the CMD-72-send-confirmation-email branch March 19, 2024 18:45
This was referenced Mar 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees

@R-Tomas-Gonzalez R-Tomas-Gonzalez

Labels
effort S Small effort task (~½ a week) — does not include review time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@R-Tomas-Gonzalez @wesleyboar