FP-1677: Update (Fix) Button Styles #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new secondary button styles changed - new tertiary button looks like old secondary button
Codecov Report
@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 67.79% 67.79%
=======================================
Files 426 426
Lines 13173 13173
Branches 2414 2414
=======================================
Hits 8930 8930
Misses 3951 3951
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
|
Merged |
2 tasks
edmondsgarrett
approved these changes
Jun 3, 2022
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Jun 4, 2022
jchuahtacc
pushed a commit
to TACC/tup-ui
that referenced
this pull request
Jun 8, 2022
* fix: clarify commands in README From: jarosenb/core-nx-demo#1 * feat(wip): integrate TACC/Core-Styles Status: no build output for lib/core-styles * fix(wip): integrate TACC/Core-Styles Status: build gives libs/core-styles/dist but no /dist/libs/core-styles * fix: accurate, consistent core-styles/package.json * fix: remove excess nx cwd option from core-styles * Revert "fix: clarify commands in README" This reverts commit fa9472a. * fix(wip): core-styles + TypeScript (no conversion) TypeScript is supported again without converting existing .js files. Status: dist output appears usable (can npm ci & npm build inside it) Problem: libs/core-styles/dist is not output to root dist * docs: core-styles README and TODO headings * fix: include & exclude correct core-styles assets Status: dist output appears usable (can npm install & build inside it) * docs: update outdated comment * feat: remove SASS (core-components, generators) CEPv2 barely uses SASS. It's only use is mixins and nesting. There are ways to do both features that are on the web standards path. Both features can be done with POstCSS - mixins can be replaced by PostCSS `@extend`: TACC/Core-Portal#639 - there is a nesting plugin (I need to test it more) * chore(version): v0.6.0-alpha * docs(changelog): update TACC/Core-Styles links * fix: README install commands * chore(version): v0.6.0-alpha, package(-lock).json * feat(core-styles): root build includes local build * chore(core-styles): version bump dist css * feat(core-styles): publish process & remove dist/ * chore(core-styles): version bump 0.6.0-alpha.1 * fix(core-styles): add missing file to package path typo caused by neglect to update path upon file move * chore(core-styles): version bump 0.6.0-alpha.2 * refactor(core-styles): move dependencies to root change comments of core-styles dependencies * fix(core-styles): remove outdated command * chore(core-styles): formate:write (limited) I can not accept all the things Prettier is doing to me CSS. I must configure before I let Prettier take control. * chore(core-styles): formate:write (html + one md) Let prettier control HTML files. Also let in one README.md's changes. * feat(core-styles): formate:write to ignore css via .prettierignore * feat(core-styles): formate:write on REAME.md's * chore(core-styles): let npm order dependencies * feat(core-styles): stylelint, config it recommends * chore(core-styles): format:write * fix(core-styles): restore deps root→core-styles CMS breaks if this is done. CMS relies on Styles dependencies. This is a known deficiency that I want to resolve. * fix(core-styles): no format css if core-styles cwd Ignore CSS when formatter is run within core-styles directory. Without this css is only ignored if formatter is run from root. * fix(core-styles): remove recommended lint rules I will add these back when I need to automate linting. Right now its just me, and this integration needs to be complete. * fix(core-styles): remove recommended lint rules I will add these back when I need to automate linting. Right now its just me, and this integration needs to be complete. * fix(core-styles): restore npm ci (cuz deps moved) * feat(core-styles): update button from Core-Portal - TACC/Core-Portal#631 - TACC/Core-Portal#654 * fix(core-styles): format write * docs(README): module usage: fix typo, drop old opt - Fix a mistake in require command. - Drop outdated `fileExt` option. Source: TACC/Core-Styles@660ce17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Fix button component styles.
Related Jira tickets:
Summary of Changes:
UI Photos:
After Merge of
mainSince #639Screen.Recording.2022-06-02.at.17.48.32.mov
Before Merge of
mainSince #639FP-1677.mov
Testing Steps: