WP-547: case insensitive email in GET tickets

[chandra-tacc]

Overview

In cases, where email in RT Ticketing system is different case vs email address stored in Core Portal user list, a bug shows up where ticket list shows up, but viewing details of the ticket (get_ticket call) fails on access control in rtUtil.djangoRT module.

When searching for tickets, rtUtil.djangoRT uses Requestors__exact search. For this search, RT uses case insensitive. So, the user is able to see all the tickets.When opening a specific ticket, portal does case sensitive check for access to the ticket in requestors and cc fields.

RT search depends on the DB settings for case sensitivity. Search api __exact converts to = in sql.

Related

• WP-547

Changes

• update djangoRT.hasAccess to do case insensitive look up for user.
• Checked that no other code in djangoRT does a lookup on user.

Testing

• Go to dashboard, check the following:
  • Ticket list shows up
  • Click on a ticket - pop up with all the details shows up.
  • reply to an existing ticket and it works.
• Run unit tests with and without the fix.
• Note: changing email case in django.contrib.auth.user_model is not setting request.user.email to upper case, request.user.email is always lower case in my tests.

UI

Notes

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.81%. Comparing base (da11ca2) to head (da626bb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   64.77%   64.81%   +0.03%     
==========================================
  Files         434      434              
  Lines       12474    12482       +8     
  Branches     2604     2603       -1     
==========================================
+ Hits         8080     8090      +10     
+ Misses       4165     4161       -4     
- Partials      229      231       +2     

Flag	Coverage Δ
javascript	69.83% <ø> (ø)
unittests	59.73% <77.77%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
server/portal/apps/tickets/rtUtil.py	46.00% <77.77%> (+15.04%)	⬆️

[edmondsgarrett]

tested, LGTM!