Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup-635: Add header demo to core-styles #258

Merged
merged 7 commits into from Nov 10, 2023

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

Overview

Feature to create header demo in core-styles.

Related

Changes

Creating demo for header.

Testing

  • Check for any structural or architectural changes recommendations.
  • The search bar does not appear on the header.

http://localhost:3000/components/detail/s-header--default
http://localhost:3000/components/detail/s-header--without-branding

UI

web mobile
Screenshot 2023-11-09 at 1 29 34 PM Screenshot 2023-11-09 at 1 29 48 PM
Screenshot 2023-11-09 at 1 29 25 PM Screenshot 2023-11-09 at 1 29 55 PM

Notes

Please check for search bar in header. Currently does not have it.

@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Nov 9, 2023
@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Nov 9, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez added the minor A feature in backward-compatible manner label Nov 9, 2023
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent to finally have in the demo!

Glad you got it working. Clean up time.

src/lib/_imports/trumps/_s-portal-nav/_s-portal-nav.hbs Outdated Show resolved Hide resolved
src/lib/_imports/trumps/s-header/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@wesleyboar wesleyboar merged commit f054695 into main Nov 10, 2023
@wesleyboar wesleyboar deleted the feat/tup-635-header-demo branch November 10, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants