Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: c-card--image-bottom #297

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

wesleyboar
Copy link
Member

Overview

Do not let image-top card's <h3> fill available space.

Related

Changes

  • changed image-top and image-bottom
    • to use same, simple grid-template-rows value
    • to not try to let client change image-height
  • documented card pattern as "Ready" (not "Work in Progress")

Testing

  1. Open http://localhost:4000/components/preview/c-card--images.
  2. Remove o-grid--col-min-width.
    This makes the card be an item in a grid with equal height rows.
  3. Verify extra space on "Card - Image bottom" is beneath image.
    (not between title and description)

UI

Before After
before after

Notes

  • The previous image-bottom grid-tempalte-rows value incorrectly assumed image was last row.
  • Both image-top and image-bottom grid-tempalte-rows values incorrectly assumed we could reliably control image height.

Do not let image-top card's `<h3>` fill available space.

Notes:
- The previous image-bottom grid-tempalte-rows value incorrectly assumed image was last row.
- Both image-top and image-bottom grid-tempalte-rows values incorrectly assumed we could reliably control image height.
@github-actions github-actions bot added the refactor Re-writes/structures code but retains behavior label Jan 10, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Jan 10, 2024
@wesleyboar wesleyboar merged commit a091305 into main Jan 10, 2024
5 checks passed
@wesleyboar wesleyboar deleted the refactor/c-card--image-bottom branch January 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A backward-compatible fix refactor Re-writes/structures code but retains behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant