Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CMD-79 navbar expanded can overflow header #315

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

wesleyboar
Copy link
Member

Overview

  • Resolve migration mistake we didn't catch — near duplicate code.
  • Fix edge-case-become-common-case* of dropdown CMS nav overflowing header.

* Edge-case because most CMS's haven't had the newer Core-Styles yet and TACC has used navbar width that avoids the bug. Become-common-case because more CMS's are getting the newer Core-Styles and TACC experienced the bug during development of TACC/tup-ui#416.

Related

Changes

  • merges near-duplicate code
  • changes height to min-height
  • adds code to avoid logo moving on navbar expand/collapse

Testing & UI

before.mov
after.mov

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Mar 8, 2024
@wesleyboar wesleyboar merged commit 1d3b816 into main Mar 8, 2024
1 of 3 checks passed
@wesleyboar wesleyboar deleted the hotfix/cmd-79-navbar-expanded-can-overflow-header branch March 8, 2024 02:31
@wesleyboar wesleyboar added the patch A backward-compatible fix label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant