feat: des-2697 add c-app-card, improve s-app-card
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature
6 tasks
wesleyboar
changed the title
c-app-card, delete s-cap-cardc-app-card
wesleyboar
changed the title
c-app-cardc-app-card, improve s-app-card
wesleyboar
added a commit
that referenced
this pull request
Mar 15, 2024
* refactor: DES-2697 s-app-card selector rename * refactor: DES-2697 c-app-card (clones s-app-card) * refactor: DES-2697 c-app-card uses class names * fix: DES-2697 support a.c-app-card * style: DES-2697 remove whitespace in cond. class * style: DES-2697 remove extra spaces * docs: DES-2697 update comments, new element names * docs: DES-2697 only use trick link css when link exists * fix: DES-2697 do not let client overwrite transparent trick link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Changes
Add
c-app-card(based off ofs-cap-card). Slight improvements tos-app-card.Status
c-app-cardc-app-cardget user to review markupif review suggests changes, those can be made
deletes-app-cardI do this in a separate PR. I want to commit the improvements here, before deleting the pattern. If it needs to be restored, restoring will happen with all improvements.
Related
Testing
UI
c-app-cards-app-card