Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cmd-105 cms hero banner pattern overflow #331

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix: cmd-105 cms hero banner pattern overflow #331

merged 4 commits into from
Apr 10, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 10, 2024 •
edited

Overview

Fix s-home-banner page overflow.

Related

Changes

  • added style to prevent overflow

Testing

  1. Open https://dev.cep.tacc.utexas.edu/.
  2. Make page have vertical scrollbar.
  3. Notice page has horizontal scrollbar.
  4. Add max-width: 100% as in this PR.
  5. Notice horizontal scrollbar disappears.

UI

Fix.CMD-105.Overflow.mov

@wesleyboar wesleyboar added the patch A backward-compatible fix label Apr 10, 2024
@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Apr 10, 2024
@wesleyboar wesleyboar merged commit cf6d3a9 into main Apr 10, 2024
@wesleyboar wesleyboar deleted the fix/CMD-105-cms-hero-banner-pattern-overflow branch April 10, 2024 00:42
@wesleyboar wesleyboar mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wesleyboar