Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/fp 1499 core-styles demo - fix css import paths #39

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 25, 2022

Overview

Fix CSS import path resolution so one can locally develop/test Core-CMS pattern library.

Related

Changes

  • Only support relative paths.
  • Resolve any PostCSS config importFrom paths.
  • Use relative import for plugin testing CSS.

Testing

  1. Use solution B from Locally Develop CMS Styles.
  2. Make a change to tup-ui/libs/core-styles code that will have a visible effect.
  3. Build the Core-CMS pattern library.
    (follow "Testing" from task/FP-1499: CMS pattern library Core-CMS#512)

Screenshots / Notes

See TACC/Core-CMS#512.

@wesleyboar wesleyboar changed the title fix(core-styles): css import paths Task/fp 1499 core-styles pattern demo - general fix for import path Jul 25, 2022
@wesleyboar wesleyboar changed the title Task/fp 1499 core-styles pattern demo - general fix for import path Task/fp 1499 core-styles pattern demo - fix css import paths Jul 25, 2022
@wesleyboar wesleyboar changed the base branch from task/fp-1499-cms-pattern-library to task/fp-1499-ui-pattern-demo July 29, 2022 15:58
@wesleyboar wesleyboar changed the title Task/fp 1499 core-styles pattern demo - fix css import paths Task/fp 1499 core-styles demo - fix css import paths Jul 29, 2022
@wesleyboar
Copy link
Member Author

Superseded by TACC/Core-Styles#35.

@wesleyboar wesleyboar closed this Jul 29, 2022
@wesleyboar wesleyboar deleted the task/fp-1499-cms-pattern-library--general-fix-for-import-paths branch July 29, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant