-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TUP-704 simplify TAM links UI #431
Conversation
08ddb96
to
6b5314e
Compare
so links or buttson can be used without inaccruate class name
This reverts commit 050f75f.
6150547
to
e6384cf
Compare
…tup-ui into feat/TUP-704-simplify-tam-links-ui
.account-body > section { | ||
display: flex; | ||
flex-direction: column; | ||
gap: 20px; | ||
height: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplifies layout. This had arranged blocks vertical and added space between them. Yes. But blocks by default arrange vertically. And spacing could differ and is unexpected to exist in one location for regularly-stacked content, so add spacing around elements as needed.
font-size: 1rem; | ||
font-style: italic; | ||
color: #484848; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was redundant or undesirable. Upon review, designer declined italics.
</> | ||
); | ||
|
||
const ManageDNs = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beware, the position of items in diff is misleading. The manageDNs
is shown further down. The managePassword
is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @R-Tomas-Gonzalez. I agree fully. I actually cleaned up and then de-cleaned the markup in prior commits. I'm trying to train myself to not combine refactors with other tasks… it's uncomfortable, but I convinced myself there was a benefit. |
@R-Tomas-Gonzalez, as available, let me know what you think of the markup (and style) changes in #439. |
Overview
Reduce complexity of TAM links UI. Add more useful context.
Status
overhaul markup completely.Related
Changes
Testing
UI
Archived