Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong service for volume to support local cms data clone #437

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 2, 2024

Overview / Changes

Move volume for local env work from cms service to postgres service.

Related

Testing

  1. I followed how-to-have-local-tup-cms-with-prod-content.md (private repo).
  2. I could not dump database because of this mistake.
  3. I fixed the mistake just like the change in this PR.
  4. I completed migration.

UI

local matches prod 20240301

@wesleyboar wesleyboar requested a review from jarosenb March 2, 2024 00:26
@wesleyboar wesleyboar changed the title fix: local env volume on cms isntead of postgres fix: incorrect volume to support local cms data clone Mar 2, 2024
@wesleyboar wesleyboar changed the title fix: incorrect volume to support local cms data clone fix: wrong service for volume to support local cms data clone Mar 2, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data is database data. It must be available in Postgres container, not CMS container.

I tested the documentation. This was the only mismatch.

@wesleyboar wesleyboar merged commit c3a0274 into main Mar 15, 2024
1 check passed
@wesleyboar wesleyboar deleted the fix/local-env-volume-on-wrong-image branch March 15, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants