-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUP-697: User Updates, Change Page Listing to Use a Plugin #438
TUP-697: User Updates, Change Page Listing to Use a Plugin #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! With some issues.
- Remove "User Updates" from output.
So CMS admin can add/remove/change heading without developers.1 - Fix URL for User Update pages.
Example: Click the name of a User Update, you get http://localhost:8000/news/latest-news107514/. - Retire the "User Updates" view.
E.g. removeUserNewsListView
; haveuser_news/list.html
oruser_news/full_list.html
, not both; renameuser_news/list_for_plugin.html
(cuz now all the plugin content is via plugins). - Rename plugins. I'm thinking:
If I've neglected or misunderstood anything, please correct me.
Footnotes
-
Consider how we can safely give admins more power. It gives us less work and gets them results faster (cuz to change this text we must change code, test, PR, review, deploy). ↩
-
No "List" because they are both a list (and Blog plugin only uses "List" to distinguish) and I don't think there will be other "User Updates" plugins. If there are, then we can append "List". ↩ ↩2
@wesleyboar 1 and 2 have been addressed by: 6ef537e For 3. I have removed For 4.a. After testing, this would be a breaking change (User News List" → "Latest User Updates.) Here's why: The plugin is already being used with it's name and therefore the template is looking for this plugin name. If we remove the plugin, we must delete first before deploying this change. For 4.b. We can make this change (Full User News List" → "User Updates) because it has not been used in prod yet. Done here: e4ced86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've broken the PR task discussion into pieces, and requested two new items.
apps/tup-cms/src/apps/user_news/templates/user_news/full_list.html
Outdated
Show resolved
Hide resolved
This reverts commit e4ced86.
…://github.com/TACC/tup-ui into sub-task/tup-697-create-full-user-news-plugin
Overview
Designers would like to edit the User Updates page. Created a plugin that adds in all of the user updates, and then adjusted the page.
Related
Changes
Testing
UI
Notes